]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit - drivers/usb/host/xhci-mem.c
xhci: Don't add a virt_dev to the devs array before it's fully allocated
authorMathias Nyman <mathias.nyman@linux.intel.com>
Fri, 8 Dec 2017 16:10:05 +0000 (18:10 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Dec 2017 17:26:34 +0000 (18:26 +0100)
commit5d9b70f7d52eb14bb37861c663bae44de9521c35
tree129fbfdca09d8e39a2887c276a77fa9a5b87ea5d
parentbe6123df1ea8f01ee2f896a16c2b7be3e4557a5a
xhci: Don't add a virt_dev to the devs array before it's fully allocated

Avoid null pointer dereference if some function is walking through the
devs array accessing members of a new virt_dev that is mid allocation.

Add the virt_dev to xhci->devs[i] _after_ the virt_device and all its
members are properly allocated.

issue found by KASAN: null-ptr-deref in xhci_find_slot_id_by_port

"Quick analysis suggests that xhci_alloc_virt_device() is not mutex
protected. If so, there is a time frame where xhci->devs[slot_id] is set
but not fully initialized. Specifically, xhci->devs[i]->udev can be NULL."

Cc: stable <stable@vger.kernel.org>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-mem.c