]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit - drivers/watchdog/loongson1_wdt.c
watchdog: loongson1_wdt: Convert to use device managed functions and other improvements
authorGuenter Roeck <linux@roeck-us.net>
Wed, 10 Apr 2019 16:27:58 +0000 (09:27 -0700)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sun, 5 May 2019 19:02:36 +0000 (21:02 +0200)
commitfd56d6c9a2ed2b82ceb24cf309482d232ad12b67
tree0104c174ddecf5b778ef8414b2f45617a99dd3bf
parent1f22b8ca6b26e47ebbd5d0c9991207fe94c4b8db
watchdog: loongson1_wdt: Convert to use device managed functions and other improvements

Use device managed functions to simplify error handling, reduce
source code size, improve readability, and reduce the likelyhood of bugs.
Other improvements as listed below.

The conversion was done automatically with coccinelle using the
following semantic patches. The semantic patches and the scripts
used to generate this commit log are available at
https://github.com/groeck/coccinelle-patches

- Drop assignments to otherwise unused variables
- Drop unnecessary braces around conditional return statements
- Drop empty remove function
- Use devm_add_action_or_reset() for calls to clk_disable_unprepare
- Introduce local variable 'struct device *dev' and use it instead of
  dereferencing it repeatedly
- Use devm_watchdog_register_driver() to register watchdog device

Cc: Keguang Zhang <keguang.zhang@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/loongson1_wdt.c