]> git.proxmox.com Git - mirror_qemu.git/commit - exec.c
exec: check that alignment is a power of two
authorDavid Hildenbrand <david@redhat.com>
Thu, 7 Jun 2018 15:47:05 +0000 (17:47 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 28 Jun 2018 17:05:31 +0000 (19:05 +0200)
commit61362b71c105ccb151ca16897a7d56534423f390
treecb8a4d1b81b3be360f4c5e802b8a2d3c4523d353
parent4d8938a05db15dea2c86c4ab9c5f872f160d2188
exec: check that alignment is a power of two

Right now we can crash QEMU using e.g.

qemu-system-x86_64 -m 256M,maxmem=20G,slots=2 \
 -object memory-backend-file,id=mem0,size=12288,mem-path=/dev/zero,align=12288 \
 -device pc-dimm,id=dimm1,memdev=mem0

qemu-system-x86_64: util/mmap-alloc.c:115:
 qemu_ram_mmap: Assertion `is_power_of_2(align)' failed

Fix this by adding a proper check.

Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20180607154705.6316-3-david@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
exec.c