]> git.proxmox.com Git - mirror_qemu.git/commit - exec.c
exec: fix TB invalidation after breakpoint insertion/deletion
authorMax Filippov <jcmvbkbc@gmail.com>
Sun, 27 May 2012 16:21:08 +0000 (20:21 +0400)
committerBlue Swirl <blauwirbel@gmail.com>
Sat, 9 Jun 2012 10:49:19 +0000 (10:49 +0000)
commit9d70c4b7b8a580959cc4f739e7c9a04964d00d46
tree8c2c748ddfac7bd9274ebf476bf4a2cc5936a843
parentc305e32f4336e29fd3f86fc32ffce7b00e5bd9e1
exec: fix TB invalidation after breakpoint insertion/deletion

tb_invalidate_phys_addr has to be called with the exact physical address of
the breakpoint we add/remove, not just the page's base address.
Otherwise we easily fail to flush the right TB.

This breakage was introduced by the commit f3705d5329 "memory: make
phys_page_find() return an unadjusted".

This appeared to work for some guest architectures because their
cpu_get_phys_page_debug implementation returns full translated physical
address, not just the base of the TARGET_PAGE_SIZE-sized page.

Reported-by: TeLeMan <geleman@gmail.com>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
exec.c