]> git.proxmox.com Git - mirror_qemu.git/commit - exec.c
exec: flush CPU TB cache in breakpoint_invalidate
authorMax Filippov <jcmvbkbc@gmail.com>
Wed, 27 Nov 2019 22:06:01 +0000 (14:06 -0800)
committerRichard Henderson <richard.henderson@linaro.org>
Tue, 11 Feb 2020 23:47:49 +0000 (15:47 -0800)
commitb55f54bc965607c45b5010a107a792ba333ba654
treee3b65ed37323b543bbe174c8d51a0cb4eab9b5ea
parente18e5501d8ac692d32657a3e1ef545b14e72b730
exec: flush CPU TB cache in breakpoint_invalidate

When a breakpoint is inserted at location for which there's currently no
virtual to physical translation no action is taken on CPU TB cache. If a
TB for that virtual address already exists but is not visible ATM the
breakpoint won't be hit next time an instruction at that address will be
executed.

Flush entire CPU TB cache in breakpoint_invalidate to force
re-translation of all TBs for the breakpoint address.

This change fixes the following scenario:
- linux user application is running
- a breakpoint is inserted from QEMU gdbstub for a user address that is
  not currently present in the target CPU TLB
- an instruction at that address is executed, but the external debugger
  doesn't get control.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Message-Id: <20191127220602.10827-2-jcmvbkbc@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
exec.c