]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - fs/cifs/connect.c
CIFS: Fix race condition on RFC1002_NEGATIVE_SESSION_RESPONSE
authorFederico Sauter <fsauter@innominate.com>
Tue, 17 Mar 2015 16:45:28 +0000 (17:45 +0100)
committerSteve French <smfrench@gmail.com>
Wed, 20 May 2015 18:25:55 +0000 (13:25 -0500)
commit4afe260bab50290a05e5732570329a530ed023f3
treef5b2c9281cd3fe80c9bfcc3679baed8155bfdc76
parentb29103076bec8316e155e71309dc0fba499022c6
CIFS: Fix race condition on RFC1002_NEGATIVE_SESSION_RESPONSE

This patch fixes a race condition that occurs when connecting
to a NT 3.51 host without specifying a NetBIOS name.
In that case a RFC1002_NEGATIVE_SESSION_RESPONSE is received
and the SMB negotiation is reattempted, but under some conditions
it leads SendReceive() to hang forever while waiting for srv_mutex.
This, in turn, sets the calling process to an uninterruptible sleep
state and makes it unkillable.

The solution is to unlock the srv_mutex acquired in the demux
thread *before* going to sleep (after the reconnect error) and
before reattempting the connection.
fs/cifs/connect.c