]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - fs/ext4/mballoc.c
ext4: fix race when setting bitmap_uptodate flag
authorTheodore Ts'o <tytso@mit.edu>
Mon, 20 Feb 2012 22:52:46 +0000 (17:52 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 20 Feb 2012 22:52:46 +0000 (17:52 -0500)
commit813e57276fd909f7d5a816ef7ca706fca491ee61
treecc2d262c0f6524f1a18d2a168d03e2ae3eb624ab
parent119c0d4460b001e44b41dcf73dc6ee794b98bd31
ext4: fix race when setting bitmap_uptodate flag

In ext4_read_{inode,block}_bitmap() we were setting bitmap_uptodate()
before submitting the buffer for read.  The is bad, since we check
bitmap_uptodate() without locking the buffer, and so if another
process is racing with us, it's possible that they will think the
bitmap is uptodate even though the read has not completed yet,
resulting in inodes and blocks potentially getting allocated more than
once if we get really unlucky.

Addresses-Google-Bug: 2828254

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/balloc.c
fs/ext4/ext4.h
fs/ext4/ialloc.c
fs/ext4/mballoc.c