]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - fs/fscache/page.c
FS-Cache: fscache_object_is_dead() has wrong logic, kill it
authorDavid Howells <dhowells@redhat.com>
Tue, 24 Feb 2015 10:52:51 +0000 (10:52 +0000)
committerDavid Howells <dhowells@redhat.com>
Thu, 2 Apr 2015 13:28:53 +0000 (14:28 +0100)
commit87021526300f1a292dd966e141e183630ac95317
treea248e5643ecdf9dae6ab6a2fe0e3d4abc415b373
parentf09b443d0e09f37121c55d7f83056f6ebff6ab4f
FS-Cache: fscache_object_is_dead() has wrong logic, kill it

fscache_object_is_dead() returns true only if the object is marked dead and
the cache got an I/O error.  This should be a logical OR instead.  Since two
of the callers got split up into handling for separate subcases, expand the
other callers and kill the function.  This is probably the right thing to do
anyway since one of the subcases isn't about the object at all, but rather
about the cache.

Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Steve Dickson <steved@redhat.com>
Acked-by: Jeff Layton <jeff.layton@primarydata.com>
fs/fscache/cookie.c
fs/fscache/page.c
include/linux/fscache-cache.h