]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - fs/gfs2/inode.c
GFS2: revert "GFS2: d_splice_alias() can't return error"
authorJ. Bruce Fields <bfields@fieldses.org>
Thu, 16 Jan 2014 18:51:07 +0000 (13:51 -0500)
committerSteven Whitehouse <swhiteho@redhat.com>
Sat, 18 Jan 2014 09:50:53 +0000 (09:50 +0000)
commitd57b9c9a999a8f4475fe73fba629c964245800ca
tree70f6d70100cdbcf9590a3383c240606f6481e47b
parent8b127d0494890ced4e35fb8eca6d6b57564ee1c6
GFS2: revert "GFS2: d_splice_alias() can't return error"

0d0d110720d7960b77c03c9f2597faaff4b484ae asserts that "d_splice_alias()
can't return error unless it was given an IS_ERR(inode)".

That was true of the implementation of d_splice_alias, but this is
really a problem with d_splice_alias: at a minimum it should be able to
return -ELOOP in the case where inserting the given dentry would cause a
directory loop.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
fs/gfs2/inode.c