]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - fs/gfs2/ops_fstype.c
GFS2: Only run logd and quota when mounted read/write
authorSteven Whitehouse <swhiteho@redhat.com>
Thu, 12 Dec 2013 11:34:09 +0000 (11:34 +0000)
committerSteven Whitehouse <swhiteho@redhat.com>
Tue, 14 Jan 2014 19:28:25 +0000 (19:28 +0000)
commit8ad151c2ac9aa106cb903cfd838b31561dbd7bcc
tree8c488968b7e9dd8ccfd254608665454b46adf46f
parentc754fbbb1b6bf462c6ddba48b19f20adf2335cac
GFS2: Only run logd and quota when mounted read/write

While investigating a rather strange bit of code in the quota
clean up function, I spotted that the reason for its existence
was that when remounting read only, we were not stopping the
quotad thread, and thus it was possible for it to still have
a reference to some of the quotas in that case.

This patch moves the logd and quota thread start and stop into
the make_fs_rw/ro functions, so that we now stop those threads
when mounted read only.

This means that quotad will always be stopped before we call
the quota clean up function, and we can thus dispose of the
(rather hackish) code that waits for it to give up its
reference on the quotas.

Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Cc: Abhijith Das <adas@redhat.com>
fs/gfs2/ops_fstype.c
fs/gfs2/quota.c
fs/gfs2/super.c