]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit - fs/io-wq.c
io-wq: exclusively gate signal based exit on get_signal() return
authorJens Axboe <axboe@kernel.dk>
Mon, 27 Sep 2021 16:04:10 +0000 (10:04 -0600)
committerJens Axboe <axboe@kernel.dk>
Mon, 27 Sep 2021 17:03:43 +0000 (11:03 -0600)
commit78f8876c2d9f6fdeb9ff62ed1911505156cd7b3d
tree48df289241a4c4c339cb74be7cd6cfa75679d650
parent7df778be2f61e1a23002d1f2f5d6aaf702771eb8
io-wq: exclusively gate signal based exit on get_signal() return

io-wq threads block all signals, except SIGKILL and SIGSTOP. We should not
need any extra checking of signal_pending or fatal_signal_pending, rely
exclusively on whether or not get_signal() tells us to exit.

The original debugging of this issue led to the false positive that we
were exiting on non-fatal signals, but that is not the case. The issue
was around races with nr_workers accounting.

Fixes: 87c169665578 ("io-wq: ensure we exit if thread group is exiting")
Fixes: 15e20db2e0ce ("io-wq: only exit on fatal signals")
Reported-by: Eric W. Biederman <ebiederm@xmission.com>
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io-wq.c