]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit - fs/nfsd/vfs.c
NFSD: Fix ia_size underflow
authorChuck Lever <chuck.lever@oracle.com>
Mon, 31 Jan 2022 18:01:53 +0000 (13:01 -0500)
committerPaolo Pisati <paolo.pisati@canonical.com>
Mon, 7 Mar 2022 10:41:56 +0000 (11:41 +0100)
commit714cd86b5093c499ec8c35e96a86f1be0721504a
tree0aa522a790d00156e6f6ee2255646d213083a656
parent7b780538c92ce9b27e35fe901a81ed6d8a60690d
NFSD: Fix ia_size underflow

BugLink: https://bugs.launchpad.net/bugs/1963889
commit e6faac3f58c7c4176b66f63def17a34232a17b0e upstream.

iattr::ia_size is a loff_t, which is a signed 64-bit type. NFSv3 and
NFSv4 both define file size as an unsigned 64-bit type. Thus there
is a range of valid file size values an NFS client can send that is
already larger than Linux can handle.

Currently decode_fattr4() dumps a full u64 value into ia_size. If
that value happens to be larger than S64_MAX, then ia_size
underflows. I'm about to fix up the NFSv3 behavior as well, so let's
catch the underflow in the common code path: nfsd_setattr().

Cc: stable@vger.kernel.org
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
fs/nfsd/vfs.c