]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - fs/xfs/libxfs/xfs_bmap.c
xfs: bmapbt checking on debug kernels too expensive
authorDave Chinner <dchinner@redhat.com>
Fri, 8 Jan 2016 00:28:49 +0000 (11:28 +1100)
committerDave Chinner <david@fromorbit.com>
Fri, 8 Jan 2016 00:28:49 +0000 (11:28 +1100)
commite35438196c6a1d8b206471d51e80c380e80e047b
tree1081125d1c6e16dc251c1502b4e9bca9f65c5d43
parent121e213eabad66c0453904d76e3eda193958acbd
xfs: bmapbt checking on debug kernels too expensive

For large sparse or fragmented files, checking every single entry in
the bmapbt on every operation is prohibitively expensive. Especially
as such checks rarely discover problems during normal operations on
high extent coutn files. Our regression tests don't tend to exercise
files with hundreds of thousands to millions of extents, so mostly
this isn't noticed.

However, trying to run things like xfs_mdrestore of large filesystem
dumps on a debug kernel quickly becomes impossible as the CPU is
completely burnt up repeatedly walking the sparse file bmapbt that
is generated for every allocation that is made.

Hence, if the file has more than 10,000 extents, just don't bother
with walking the tree to check it exhaustively. The btree code has
checks that ensure that the newly inserted/removed/modified record
is correctly ordered, so the entrie tree walk in thses cases has
limited additional value.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/libxfs/xfs_bmap.c