]> git.proxmox.com Git - mirror_qemu.git/commit - gdbstub.c
gdbstub: Fix handler for 'F' packet
authorSandra Loosemore <sandra@codesourcery.com>
Tue, 27 Aug 2019 22:33:17 +0000 (16:33 -0600)
committerAlex Bennée <alex.bennee@linaro.org>
Wed, 28 Aug 2019 09:11:15 +0000 (10:11 +0100)
commitc6ee95216b1a98c909e24659741622aaf563df86
tree5c260ef7a71b827bfd63904ecfe250943e8460e4
parent2bdec3984850a093a6bd97cf0a7183dbb877eb38
gdbstub: Fix handler for 'F' packet

Handling of the 'F' packet has been broken since commit
4b20fab101b9e2d0fb47454209637a17fc7a13d5, which converted it to use
the new packet parsing infrastructure.  Per the GDB RSP specification

https://sourceware.org/gdb/current/onlinedocs/gdb/The-F-Reply-Packet.html

the second parameter may be omitted, but the rewritten implementation
was failing to recognize this case.  The result was that QEMU was
repeatedly resending the fileio request and ignoring GDB's replies of
successful completion.  This patch restores the behavior of the
previous code in allowing the errno parameter to be omitted and
passing 0 to the callback in that case.

Signed-off-by: Sandra Loosemore <sandra@codesourcery.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20190827223317.8614-1-sandra@codesourcery.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
gdbstub.c