]> git.proxmox.com Git - mirror_qemu.git/commit - hw/char/spapr_vty.c
pseries: Check we have a chardev in spapr_vty_init()
authorMichael Ellerman <michael@ellerman.id.au>
Sun, 13 Nov 2011 17:18:59 +0000 (17:18 +0000)
committerAlexander Graf <agraf@suse.de>
Fri, 18 Nov 2011 13:22:46 +0000 (14:22 +0100)
commit57285302af51a8bae334c03e1f8243e935373953
tree112a22bec76cc4ffe6725241f73b7d22a01a7fc5
parent5435352ce6abfb8a7540ae7d47e981d329120cca
pseries: Check we have a chardev in spapr_vty_init()

If qemu is run like:

 qemu-system-ppc64 -nodefaults -device spapr-vty

We end up in spapr_vty_init() with dev->chardev == NULL. Currently
that leads to a segfault because we unconditionally call
qemu_chr_add_handlers().

Although we could make that call conditional, I think a spapr-vty
without a chardev is basically useless so fail the init. This is
similar to what the serial code does for example.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Alexander Graf <agraf@suse.de>
hw/spapr_vty.c