]> git.proxmox.com Git - qemu.git/commit - hw/display/qxl.c
qxl: Don't drop client capability bits
authorMarkus Armbruster <armbru@redhat.com>
Thu, 10 Jan 2013 13:24:50 +0000 (14:24 +0100)
committerGerd Hoffmann <kraxel@redhat.com>
Mon, 14 Jan 2013 07:59:38 +0000 (08:59 +0100)
commit08688af04dc1137ac2f420b35c235183926b4a23
treec69d3e3b9e8d1ab7a5e0f394c4d91ec51babb03c
parentbc5f92e5db6f303e73387278e32f8669f0abf0e5
qxl: Don't drop client capability bits

interface_set_client_capabilities() copies only the first few bits,
because it falls into a Classic C trap: you can declare a parameter
uint8_t caps[58], but the resulting parameter type is uint8_t *, not
uint8_t[58].  In particular, sizeof(caps) is sizeof(uint8_t *), not
the intended sizeof(uint8_t[58]).

Harmless, because the bits aren't used, yet.  Broken in commit
c10018d6.  Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
hw/qxl.c