]> git.proxmox.com Git - mirror_qemu.git/commit - hw/ide/ahci.c
ahci: Fix SDB FIS Construction
authorJohn Snow <jsnow@redhat.com>
Wed, 1 Oct 2014 22:55:51 +0000 (18:55 -0400)
committerStefan Hajnoczi <stefanha@redhat.com>
Mon, 3 Nov 2014 09:48:41 +0000 (09:48 +0000)
commit54a7f8f38ddf4711ee8bf773b5066337b045a343
tree73f759d51ba0ee79773cf79795019bb1bd90265d
parent659142ecf71a0da240ab0ff7cf929ee25c32b9bc
ahci: Fix SDB FIS Construction

The SDB FIS creation was mangled;
We were writing the error byte to byte 0,
and omitting the SDB FIS magic byte.

Though the SDB packet layout states that:
byte 0: Must be 0xA1 to indicate SDB FIS.
byte 1: Port multiplier select & other flags
byte 2: status byte.
byte 3: error byte.

This patch adds an SDB FIS structure with
human-readable names, and ensures that we
are filling the structure appropriately.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Tested-by: Michael S. Tsirkin <mst@redhat.com>
Message-id: 1412204151-18117-7-git-send-email-jsnow@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/ide/ahci.c
hw/ide/ahci.h