]> git.proxmox.com Git - mirror_qemu.git/commit - hw/misc/ivshmem.c
ivshmem: Disable irqfd on device reset
authorLadi Prosek <lprosek@redhat.com>
Mon, 11 Dec 2017 07:21:10 +0000 (08:21 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 7 Feb 2018 13:09:24 +0000 (14:09 +0100)
commita40227911c4cac4ac2551c57058d220baae4e91f
tree0975301d93622dcbc4460d3f2fb9ad91a33b79d3
parent0b88dd942073e7e65f095551d60be5dc0c8e1413
ivshmem: Disable irqfd on device reset

The effects of ivshmem_enable_irqfd() was not undone on device reset.

This manifested as:
ivshmem_add_kvm_msi_virq: Assertion `!s->msi_vectors[vector].pdev' failed.

when irqfd was enabled before reset and then enabled again after reset, making
ivshmem_enable_irqfd() run for the second time.

To reproduce, run:

  ivshmem-server

and QEMU with:

  -device ivshmem-doorbell,chardev=iv
  -chardev socket,path=/tmp/ivshmem_socket,id=iv

then install the Windows driver, at the time of writing available at:

https://github.com/virtio-win/kvm-guest-drivers-windows/tree/master/ivshmem

and crash-reboot the guest by inducing a BSOD.

Signed-off-by: Ladi Prosek <lprosek@redhat.com>
Message-Id: <20171211072110.9058-5-lprosek@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/misc/ivshmem.c