]> git.proxmox.com Git - mirror_qemu.git/commit - hw/scsi/virtio-scsi.c
virtio-scsi: define dummy handle_output for vhost-scsi vqs
authorMing Lei <ming.lei@canonical.com>
Thu, 19 Jun 2014 08:12:00 +0000 (16:12 +0800)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 19 Jun 2014 08:15:48 +0000 (10:15 +0200)
commit91d670fbf9945ca4ecbd123affb36889e7fe8a5d
tree7f4309f2b1db8001c810f99d215fd8a7e41ac2a9
parent8c215a9fbdfe9476dd8b907681fc38d0bae78854
virtio-scsi: define dummy handle_output for vhost-scsi vqs

vhost userspace needn't to handle vq's notification from guest,
so define dummy handle_output callback for all vqs of vhost-scsi.

In some corner cases(such as when handling vq's reset from VM), virtio-pci
still trys to handle pending virtio-scsi events, then object check failure
inside virtio_scsi_handle_event() for vhost-scsi can be triggered.

The issue can be reproduced by 'rmmod virtio-scsi', 'system sleep' or reboot
inside VM.

Cc: qemu-stable@nongnu.org
Cc: Anthony Liguori <aliguori@amazon.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/scsi/vhost-scsi.c
hw/scsi/virtio-scsi.c
include/hw/virtio/virtio-scsi.h