]> git.proxmox.com Git - mirror_qemu.git/commit - include/hw/ppc/spapr.h
spapr: Minor cleanups to events handling
authorDavid Gibson <david@gibson.dropbear.id.au>
Wed, 12 Jul 2017 01:55:53 +0000 (11:55 +1000)
committerDavid Gibson <david@gibson.dropbear.id.au>
Mon, 17 Jul 2017 05:07:05 +0000 (15:07 +1000)
commit5341258e863e8e8503ca0e01306cfb0d8f4b8e63
tree5179f7615874449cb51e250df2a1e2f1e45e92ef
parentfd38804b388fdd5f3abd108f260d3e9d625ff7ad
spapr: Minor cleanups to events handling

The rtas_error_log structure is marked packed, which strongly suggests its
precise layout is important to match an external interface.  Along with
that one could expect it to have a fixed endianness to match the same
interface.  That used to be the case - matching the layout of PAPR RTAS
event format and requiring BE fields.

Now, however, it's only used embedded within sPAPREventLogEntry with the
fields in native order, since they're processed internally.

Clear that up by removing the nested structure in sPAPREventLogEntry.
struct rtas_error_log is moved back to spapr_events.c where it is used as
a temporary to help convert the fields in sPAPREventLogEntry to the correct
in memory format when delivering an event to the guest.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
hw/ppc/spapr.c
hw/ppc/spapr_events.c
include/hw/ppc/spapr.h