]> git.proxmox.com Git - mirror_qemu.git/commit - include/hw/ppc/spapr_drc.h
spapr_drc: Prevent detach racing against attach for CPU DR
authorBharata B Rao <bharata@linux.vnet.ibm.com>
Thu, 12 May 2016 03:48:21 +0000 (09:18 +0530)
committerDavid Gibson <david@gibson.dropbear.id.au>
Fri, 17 Jun 2016 06:33:48 +0000 (16:33 +1000)
commitaab99135b63522267c6fdae04712cb2f02c8c7de
treec6ec4a08e7f11d8f62e14ed62c94e80722218253
parent4a4b344c7ccdeac28c2e65e51ddbe3acfb41b883
spapr_drc: Prevent detach racing against attach for CPU DR

If a CPU is hot removed while hotplug of the same is still in progress,
the guest crashes. Prevent this by ensuring that detach is done only
after attach has completed.

The existing code already prevents such race for PCI hotplug. However
given that CPU is a logical DR unlike PCI and starts with ISOLATED
state, we need a logic that works for CPU too.

Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
               [Don't set awaiting_attach for PCI devices]
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
hw/ppc/spapr_drc.c
include/hw/ppc/spapr_drc.h