]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - include/linux/bio.h
bio: fix improper use of smp_mb__before_atomic()
authorAndrea Parri <andrea.parri@amarulasolutions.com>
Mon, 20 May 2019 17:23:56 +0000 (19:23 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commitc6b7e72da79fbb9ed9daedc5a9a00bd3892a6c6b
treec7f4b639342e3e34dd243bd78f8b1a6931a1142e
parent05f94312110fff933030d4a807c7ecada7c14f2a
bio: fix improper use of smp_mb__before_atomic()

BugLink: https://bugs.launchpad.net/bugs/1838700
commit f381c6a4bd0ae0fde2d6340f1b9bb0f58d915de6 upstream.

This barrier only applies to the read-modify-write operations; in
particular, it does not apply to the atomic_set() primitive.

Replace the barrier with an smp_mb().

Fixes: dac56212e8127 ("bio: skip atomic inc/dec of ->bi_cnt for most use cases")
Cc: stable@vger.kernel.org
Reported-by: "Paul E. McKenney" <paulmck@linux.ibm.com>
Reported-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Andrea Parri <andrea.parri@amarulasolutions.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org
Cc: "Paul E. McKenney" <paulmck@linux.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
include/linux/bio.h