]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - include/linux/cpuhotplug.h
clocksource/dummy_timer: Move hotplug callback after the real timers
authorThomas Gleixner <tglx@linutronix.de>
Thu, 15 Dec 2016 11:01:05 +0000 (12:01 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 15 Dec 2016 11:09:20 +0000 (12:09 +0100)
commit9bf11ecce5a2758e5a097c2f3a13d08552d0d6f9
tree3d6e66b739564b94a05fce5d9076bf48d5de2c4f
parentf082f02c4731900a5065de69eb0d8cb5aab66196
clocksource/dummy_timer: Move hotplug callback after the real timers

When the dummy timer callback is invoked before the real timer callbacks,
then it tries to install that timer for the starting CPU. If the platform
does not have a broadcast timer installed the installation fails with a
kernel crash. The crash happens due to a unconditional deference of the non
available broadcast device. This needs to be fixed in the timer core code.

But even when this is fixed in the core code then installing the dummy
timer before the real timers is a pointless exercise.

Move it to the end of the callback list.

Fixes: 00c1d17aab51 ("clocksource/dummy_timer: Convert to hotplug state machine")
Reported-and-tested-by: Mason <slash.tmp@free.fr>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Anna-Maria Gleixner <anna-maria@linutronix.de>
Cc: Richard Cochran <rcochran@linutronix.de>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Cc: Sebastian Frias <sf84@laposte.net>
Cc: Thibaud Cornic <thibaud_cornic@sigmadesigns.com>
Cc: Robin Murphy <robin.murphy@arm.com>
Link: http://lkml.kernel.org/r/1147ef90-7877-e4d2-bb2b-5c4fa8d3144b@free.fr
include/linux/cpuhotplug.h