]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - include/linux/olpc-ec.h
Staging: olpc_dcon: replace some magic numbers
authorJens Frederich <jfrederich@gmail.com>
Thu, 15 Aug 2013 19:34:55 +0000 (21:34 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 16 Aug 2013 00:22:27 +0000 (17:22 -0700)
commit98d4f93c79b002f85480320fe63fefaa31d58b6c
tree0bd102d568f888d5e1eb4e359018211851bf93fd
parent01f865ba4a1ee95d4828b4f3fa69d68f9ac4b9ba
Staging: olpc_dcon: replace some magic numbers

This patch replace some magic numbers. I believe it makes
the driver more readable.

The magic number 0x26 is the XO system embedded controller
(EC) command 'DCON power enable/disable'.

Number 0x41, and 0x42 are special memory controller settings
register.  The 0x41 initialize bit sequence 0x101 means:
enable memory power down function and special SDRAM clock
delay for synchronize SDRAM output and clock signal.

The 0x42 initialize squence 0x101 is wrong.  According to
the specification Bit 8 is reserved, thus not in use.
I removed it.

Signed-off-by: Jens Frederich <jfrederich@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/olpc_dcon/olpc_dcon.c
drivers/staging/olpc_dcon/olpc_dcon.h
include/linux/olpc-ec.h