]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - include/linux/pci.h
PCI: Fix return value from pci_user_{read,write}_config_*()
authorGavin Shan <gwshan@linux.vnet.ibm.com>
Wed, 21 May 2014 05:23:30 +0000 (15:23 +1000)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 27 May 2014 23:10:16 +0000 (17:10 -0600)
commitd97ffe236894856d08146390ef3fbe6448a8ac2b
tree0935d466ca429a5b61a9b82ed44a6c623175964f
parenta43ae58c848cfbadaba81c8d63202b4487f922a0
PCI: Fix return value from pci_user_{read,write}_config_*()

The PCI user-space config accessors pci_user_{read,write}_config_*() return
negative error numbers, which were introduced by commit 34e3207205ef
("PCI: handle positive error codes").  That patch converted all positive
error numbers from platform-specific PCI config accessors to -EINVAL, which
means the callers don't know anything about the specific cause of the
failure.

The patch fixes the issue by converting the positive PCIBIOS_* error values
to generic negative error numbers with pcibios_err_to_errno().

[bhelgaas: changelog]
Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Greg Thelen <gthelen@google.com>
drivers/pci/access.c
include/linux/pci.h