]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - include/linux/skbuff.h
networking: make skb_pull & friends return void pointers
authorJohannes Berg <johannes.berg@intel.com>
Fri, 16 Jun 2017 12:29:22 +0000 (14:29 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 16 Jun 2017 15:48:39 +0000 (11:48 -0400)
commitaf72868b9070d1b843c829f0d0d0b22c04a20815
tree537bb273e315e1238cff969adbfc70cb35ba9a44
parent4df864c1d9afb46e2461a9f808d9f11a42d31bad
networking: make skb_pull & friends return void pointers

It seems like a historic accident that these return unsigned char *,
and in many places that means casts are required, more often than not.

Make these functions return void * and remove all the casts across
the tree, adding a (u8 *) cast only where the unsigned char pointer
was used directly, all done with the following spatch:

    @@
    expression SKB, LEN;
    typedef u8;
    identifier fn = {
            skb_pull,
            __skb_pull,
            skb_pull_inline,
            __pskb_pull_tail,
            __pskb_pull,
            pskb_pull
    };
    @@
    - *(fn(SKB, LEN))
    + *(u8 *)fn(SKB, LEN)

    @@
    expression E, SKB, LEN;
    identifier fn = {
            skb_pull,
            __skb_pull,
            skb_pull_inline,
            __pskb_pull_tail,
            __pskb_pull,
            pskb_pull
    };
    type T;
    @@
    - E = ((T *)(fn(SKB, LEN)))
    + E = fn(SKB, LEN)

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
13 files changed:
drivers/bluetooth/hci_nokia.c
drivers/isdn/i4l/isdn_ppp.c
drivers/net/wan/hdlc_ppp.c
drivers/nfc/nxp-nci/firmware.c
drivers/scsi/fnic/fnic_fcs.c
drivers/scsi/qedf/qedf_main.c
include/linux/skbuff.h
net/bluetooth/a2mp.c
net/core/skbuff.c
net/ipv4/ipmr.c
net/ipv4/xfrm4_mode_beet.c
net/ipv6/ip6mr.c
net/ipv6/xfrm6_mode_beet.c