]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit - include/net/sock.h
tcp: do not release socket ownership in tcp_close()
authorEric Dumazet <edumazet@google.com>
Tue, 2 Oct 2018 06:24:26 +0000 (23:24 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 3 Oct 2018 05:17:35 +0000 (22:17 -0700)
commit8873c064d1de579ea23412a6d3eee972593f142b
treec7c1d16fc8403b48ff2b5f0cd8775b9f383ceea5
parent744486d426dce4e4dc25fd2ce750116a0025736c
tcp: do not release socket ownership in tcp_close()

syzkaller was able to hit the WARN_ON(sock_owned_by_user(sk));
in tcp_close()

While a socket is being closed, it is very possible other
threads find it in rtnetlink dump.

tcp_get_info() will acquire the socket lock for a short amount
of time (slow = lock_sock_fast(sk)/unlock_sock_fast(sk, slow);),
enough to trigger the warning.

Fixes: 67db3e4bfbc9 ("tcp: no longer hold ehash lock while calling tcp_get_info()")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/sock.h
net/core/sock.c
net/ipv4/tcp.c