]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit - kernel/cgroup.c
cgroup: disallow rename(2) if sane_behavior
authorTejun Heo <tj@kernel.org>
Fri, 14 Jun 2013 18:18:22 +0000 (11:18 -0700)
committerTejun Heo <tj@kernel.org>
Tue, 18 Jun 2013 15:14:23 +0000 (08:14 -0700)
commit6db8e85c5c1f89cd0183b76dab027c81009f129f
tree6195edbc8abb6645d39a4986fd2d48c89bbefa92
parentf63674fd0d6afa1ba24309aee1f8c60195d39041
cgroup: disallow rename(2) if sane_behavior

cgroup's rename(2) isn't a proper migration implementation - it can't
move the cgroup to a different parent in the hierarchy.  All it can do
is swapping the name string for that cgroup.  This isn't useful and
can mislead users to think that cgroup supports proper cgroup-level
migration.  Disallow rename(2) if sane_behavior.

v2: Fail with -EPERM instead of -EINVAL so that it matches the vfs
    return value when ->rename is not implemented as suggested by Li.

Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Li Zefan <lizefan@huawei.com>
include/linux/cgroup.h
kernel/cgroup.c