]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - kernel/locking/lockdep.c
locking/lockdep: Do not record IRQ state within lockdep code
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Wed, 4 Apr 2018 18:06:30 +0000 (14:06 -0400)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:42:52 +0000 (19:42 -0600)
commitc9d50a01759e8cc32a7e8f9a282a789b1faf880b
tree74a555f0426d41f9bf4ccb9ad7f6aafa80fc50dd
parentca7f67d9d7b4aa8f183a4580790b0773e01bdb71
locking/lockdep: Do not record IRQ state within lockdep code

BugLink: https://bugs.launchpad.net/bugs/1835845
[ Upstream commit fcc784be837714a9173b372ff9fb9b514590dad9 ]

While debugging where things were going wrong with mapping
enabling/disabling interrupts with the lockdep state and actual real
enabling and disabling interrupts, I had to silent the IRQ
disabling/enabling in debug_check_no_locks_freed() because it was
always showing up as it was called before the splat was.

Use raw_local_irq_save/restore() for not only debug_check_no_locks_freed()
but for all internal lockdep functions, as they hide useful information
about where interrupts were used incorrectly last.

Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Will Deacon <will.deacon@arm.com>
Link: https://lkml.kernel.org/lkml/20180404140630.3f4f4c7a@gandalf.local.home
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
kernel/locking/lockdep.c