]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit - kernel/module.c
kernel: module: Use struct_size() helper
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 6 Jun 2019 18:18:53 +0000 (13:18 -0500)
committerJessica Yu <jeyu@kernel.org>
Fri, 7 Jun 2019 08:56:32 +0000 (10:56 +0200)
commit8d1b73dd25ff92c3fa9807a20c22fa2b44c07336
tree6212b290118a7f3c96aff18c0c1bac6da62b297f
parent6e6de3dee51a439f76eb73c22ae2ffd2c9384712
kernel: module: Use struct_size() helper

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct module_sect_attrs {
...
        struct module_sect_attr attrs[0];
};

Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes.

So, replace the following form:

sizeof(*sect_attrs) + nloaded * sizeof(sect_attrs->attrs[0]

with:

struct_size(sect_attrs, attrs, nloaded)

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Jessica Yu <jeyu@kernel.org>
kernel/module.c