]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - kernel/pid_namespace.c
pid_ns: Sleep in TASK_INTERRUPTIBLE in zap_pid_ns_processes
authorEric W. Biederman <ebiederm@xmission.com>
Thu, 11 May 2017 23:21:01 +0000 (18:21 -0500)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Tue, 20 Jun 2017 10:18:05 +0000 (12:18 +0200)
commit53eae9ec5e0cead41a3d9ca1b12d5fc782a3d906
tree43de1de96ae8678b5a73c1726b96df90b96e0c6e
parent38082b73cf1768b1332d84dfc1dcb33300f216e7
pid_ns: Sleep in TASK_INTERRUPTIBLE in zap_pid_ns_processes

BugLink: http://bugs.launchpad.net/bugs/1694621
commit b9a985db98961ae1ba0be169f19df1c567e4ffe0 upstream.

The code can potentially sleep for an indefinite amount of time in
zap_pid_ns_processes triggering the hung task timeout, and increasing
the system average.  This is undesirable.  Sleep with a task state of
TASK_INTERRUPTIBLE instead of TASK_UNINTERRUPTIBLE to remove these
undesirable side effects.

Apparently under heavy load this has been allowing Chrome to trigger
the hung time task timeout error and cause ChromeOS to reboot.

Reported-by: Vovo Yang <vovoy@google.com>
Reported-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Fixes: 6347e9009104 ("pidns: guarantee that the pidns init will be the last pidns process reaped")
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
kernel/pid_namespace.c