]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit - kernel/smp.c
sched: Replace rq::wake_list
authorPeter Zijlstra <peterz@infradead.org>
Tue, 26 May 2020 16:11:04 +0000 (18:11 +0200)
committerIngo Molnar <mingo@kernel.org>
Thu, 28 May 2020 08:54:16 +0000 (10:54 +0200)
commita148866489fbe243c936fe43e4525d8dbfa0318f
tree5431e4fee20e79f58991f4c58161adf21b287ad5
parent126c2092e5c8b28623cb890cd2930aa292410676
sched: Replace rq::wake_list

The recent commit: 90b5363acd47 ("sched: Clean up scheduler_ipi()")
got smp_call_function_single_async() subtly wrong. Even though it will
return -EBUSY when trying to re-use a csd, that condition is not
atomic and still requires external serialization.

The change in ttwu_queue_remote() got this wrong.

While on first reading ttwu_queue_remote() has an atomic test-and-set
that appears to serialize the use, the matching 'release' is not in
the right place to actually guarantee this serialization.

The actual race is vs the sched_ttwu_pending() call in the idle loop;
that can run the wakeup-list without consuming the CSD.

Instead of trying to chain the lists, merge them.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20200526161908.129371594@infradead.org
include/linux/sched.h
include/linux/smp.h
kernel/sched/core.c
kernel/sched/idle.c
kernel/sched/sched.h
kernel/smp.c