]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit - kernel/trace/trace_events_trigger.c
tracing: Fix event trigger to accept redundant spaces
authorMasami Hiramatsu <mhiramat@kernel.org>
Sat, 20 Jun 2020 03:46:03 +0000 (12:46 +0900)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Wed, 24 Jun 2020 01:51:40 +0000 (21:51 -0400)
commit6784beada631800f2c5afd567e5628c843362cee
treefff04171d80ec3c614c3c783eb95f41697744107
parent6c95503c292610ff2898b4271c510c16efdcd4e1
tracing: Fix event trigger to accept redundant spaces

Fix the event trigger to accept redundant spaces in
the trigger input.

For example, these return -EINVAL

echo " traceon" > events/ftrace/print/trigger
echo "traceon  if common_pid == 0" > events/ftrace/print/trigger
echo "disable_event:kmem:kmalloc " > events/ftrace/print/trigger

But these are hard to find what is wrong.

To fix this issue, use skip_spaces() to remove spaces
in front of actual tokens, and set NULL if there is no
token.

Link: http://lkml.kernel.org/r/159262476352.185015.5261566783045364186.stgit@devnote2
Cc: Tom Zanussi <zanussi@kernel.org>
Cc: stable@vger.kernel.org
Fixes: 85f2b08268c0 ("tracing: Add basic event trigger framework")
Reviewed-by: Tom Zanussi <zanussi@kernel.org>
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_events_trigger.c