]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - lib/pci_iomap.c
cleanup IORESOURCE_CACHEABLE vs ioremap()
authorDan Williams <dan.j.williams@intel.com>
Tue, 11 Aug 2015 03:07:06 +0000 (23:07 -0400)
committerDan Williams <dan.j.williams@intel.com>
Tue, 11 Aug 2015 03:07:06 +0000 (23:07 -0400)
commit92b19ff50e8f242392d78b2aacc5b5b672f1796b
tree463927d91228174419ba1fe327f3cec6b9a2615a
parent2584cf83578c26db144730ef498f4070f82ee3ea
cleanup IORESOURCE_CACHEABLE vs ioremap()

Quoting Arnd:
    I was thinking the opposite approach and basically removing all uses
    of IORESOURCE_CACHEABLE from the kernel. There are only a handful of
    them.and we can probably replace them all with hardcoded
    ioremap_cached() calls in the cases they are actually useful.

All existing usages of IORESOURCE_CACHEABLE call ioremap() instead of
ioremap_nocache() if the resource is cacheable, however ioremap() is
uncached by default. Clearly none of the existing usages care about the
cacheability. Particularly devm_ioremap_resource() never worked as
advertised since it always fell back to plain ioremap().

Clean this up as the new direction we want is to convert
ioremap_<type>() usages to memremap(..., flags).

Suggested-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
arch/arm/mach-clps711x/board-cdb89712.c
arch/powerpc/kernel/pci_of_scan.c
arch/sparc/kernel/pci.c
drivers/pci/probe.c
drivers/pnp/manager.c
drivers/scsi/aic94xx/aic94xx_init.c
drivers/scsi/arcmsr/arcmsr_hba.c
drivers/scsi/mvsas/mv_init.c
drivers/video/fbdev/ocfb.c
lib/devres.c
lib/pci_iomap.c