]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit - lib/rhashtable.c
rhashtable: use struct_size() in kvzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 11 Apr 2019 23:43:06 +0000 (18:43 -0500)
committerDavid S. Miller <davem@davemloft.net>
Sat, 13 Apr 2019 00:31:33 +0000 (17:31 -0700)
commitc252aa3e8ed3ac54060b1838f6a47f29799a133d
treeb0843e0b11610b2dbf39821b677cf9f0a16c5493
parent9d60f0ea1c555045aa2dcf15877b178adba3d697
rhashtable: use struct_size() in kvzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along with
memory for some number of elements for that array.  For example:

struct foo {
    int stuff;
    struct boo entry[];
};

size = sizeof(struct foo) + count * sizeof(struct boo);
instance = kvzalloc(size, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kvzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
lib/rhashtable.c