]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - lib/test_static_keys.c
locking/static_keys: Avoid nested functions
authorArnd Bergmann <arnd@arndb.de>
Mon, 8 Feb 2016 14:36:52 +0000 (15:36 +0100)
committerIngo Molnar <mingo@kernel.org>
Tue, 9 Feb 2016 09:27:29 +0000 (10:27 +0100)
commit975db45e9cc561bf8a7eddfa0705d3a078ec184f
treeaa9cb3419b3e5eb1ff312a90a32c1fbe3474ea21
parent2a96fd7417a0eb501edfde9713555bd7c2eda302
locking/static_keys: Avoid nested functions

clang does not support nested functions inside of an array definition:

  lib/test_static_keys.c:105:16: error: function definition is not allowed here
                          .test_key       = test_key_func(&old_true_key, static_key_true),
  lib/test_static_keys.c:50:20: note: expanded from macro 'test_key_func'
          ({bool func(void) { return branch(key); } func; })

That code appears to be a little too clever, so this simplifies it
a bit by defining functions outside of the array.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Jason Baron <jbaron@akamai.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-arm-kernel@lists.infradead.org
Link: http://lkml.kernel.org/r/1454942223-2781480-1-git-send-email-arnd@arndb.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
lib/test_static_keys.c