]> git.proxmox.com Git - mirror_qemu.git/commit - linux-user/elfload.c
linux-user: init_guest_space: Clarify page alignment logic
authorLuke Shumaker <lukeshu@parabola.nu>
Thu, 28 Dec 2017 18:08:08 +0000 (13:08 -0500)
committerLaurent Vivier <laurent@vivier.eu>
Fri, 9 Mar 2018 20:29:24 +0000 (21:29 +0100)
commit293f20600896d18c05880fb003f08d281b3156cb
tree629b6bfbf71614459b670e54d245ac740598f714
parente7ea02e62a37ea94a2ee6cc99e7c682ef0e61e9f
linux-user: init_guest_space: Clarify page alignment logic

There are 3 parts to this change:
 - Add a comment showing the relative sizes and positions of the blocks of
   memory
 - introduce and use new aligned_{start,size} instead of adjusting
   real_{start_size}
 - When we clean up (on failure), munmap(real_start, real_size) instead of
   munmap(aligned_start, aligned_size).  It *shouldn't* make any
   difference, but I will admit that this does mean we are making the
   syscall with different values, so this isn't quite a no-op patch.

Signed-off-by: Luke Shumaker <lukeshu@parabola.nu>
Message-Id: <20171228180814.9749-6-lukeshu@lukeshu.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
linux-user/elfload.c