]> git.proxmox.com Git - mirror_qemu.git/commit - migration/migration.c
migration: Don't do migrate cleanup if during postcopy resume
authorPeter Xu <peterx@redhat.com>
Thu, 8 Jul 2021 19:06:52 +0000 (15:06 -0400)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Tue, 13 Jul 2021 15:21:57 +0000 (16:21 +0100)
commitca30f24d12c9ba1fc0654e6e983f950f7792a217
treee5b23a5d0940937dda675773eb575d112ccca73e
parent2e3e3da3c2ad559d1255a9a3bf3df0782c2cf231
migration: Don't do migrate cleanup if during postcopy resume

Below process could crash qemu with postcopy recovery:

  1. (hmp) migrate -d ..
  2. (hmp) migrate_start_postcopy
  3. [network down, postcopy paused]
  4. (hmp) migrate -r $WRONG_PORT
     when try the recover on an invalid $WRONG_PORT, cleanup_bh will be cleared
  5. (hmp) migrate -r $RIGHT_PORT
     [qemu crash on assert(cleanup_bh)]

The thing is we shouldn't cleanup if it's postcopy resume; the error is set
mostly because the channel is wrong, so we return directly waiting for the user
to retry.

migrate_fd_cleanup() should only be called when migration is cancelled or
completed.

Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20210708190653.252961-3-peterx@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
migration/migration.c