]> git.proxmox.com Git - mirror_qemu.git/commit - migration/migration.c
migration/multifd: Change multifd_load_cleanup() signature and usage
authorLeonardo Bras <leobras@redhat.com>
Fri, 10 Feb 2023 06:36:28 +0000 (03:36 -0300)
committerJuan Quintela <quintela@redhat.com>
Mon, 13 Feb 2023 02:44:44 +0000 (03:44 +0100)
commite5bac1f525472d6042a4cdba31dda5825cde0086
treed120569aceec723b6b3117e8ffd9508bfdf6e4a2
parent5655aab0794b5c82e61683cab215c5f745be8af3
migration/multifd: Change multifd_load_cleanup() signature and usage

Since it's introduction in commit f986c3d256 ("migration: Create multifd
migration threads"), multifd_load_cleanup() never returned any value
different than 0, neither set up any error on errp.

Even though, on process_incoming_migration_bh() an if clause uses it's
return value to decide on setting autostart = false, which will never
happen.

In order to simplify the codebase, change multifd_load_cleanup() signature
to 'void multifd_load_cleanup(void)', and for every usage remove error
handling or decision made based on return value != 0.

Fixes: b5eea99ec2 ("migration: Add yank feature")
Reported-by: Li Xiaohui <xiaohli@redhat.com>
Signed-off-by: Leonardo Bras <leobras@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
migration/migration.c
migration/multifd.c
migration/multifd.h