]> git.proxmox.com Git - mirror_qemu.git/commit - migration/savevm.c
snapshot: Reset err to NULL to avoid double free
authorChris Spiegel <chris.spiegel@cypherpath.com>
Mon, 6 Oct 2014 16:33:45 +0000 (09:33 -0700)
committerStefan Hajnoczi <stefanha@redhat.com>
Mon, 3 Nov 2014 09:48:41 +0000 (09:48 +0000)
commitba2b22888c43fdf36f3ae0553c89013616e9c44a
tree26339a068f56bc5e24fbd3b66f314295270a9f4a
parent54a7f8f38ddf4711ee8bf773b5066337b045a343
snapshot: Reset err to NULL to avoid double free

If an error occurs in bdrv_snapshot_delete_by_id_or_name(), "err" is
freed.  If "err" is not set to NULL before calling
bdrv_snapshot_delete_by_id_or_name() again, it will not be updated on
error, and will be freed again.

This can be triggered by starting a VM with at least two drives and then
attempting to delete a non-existent snapshot.

Broken in commit a89d89d.

Signed-off-by: Chris Spiegel <chris.spiegel@cypherpath.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-id: 1412613225-32676-1-git-send-email-chris.spiegel@cypherpath.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
savevm.c