]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - mm/pagewalk.c
mm/pagewalk.c: report holes in hugetlb ranges
authorJann Horn <jannh@google.com>
Wed, 31 Jan 2018 17:01:30 +0000 (18:01 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 14 Mar 2018 10:40:57 +0000 (11:40 +0100)
commit878bd8aebb52450fc702dd24bc7af6374561a0ba
tree840f5a4a4362a868fc4855b8728ce91b1622ae57
parentd74b514ac9fa93c0f070ec177c90b43e36a0c800
mm/pagewalk.c: report holes in hugetlb ranges

CVE-2017-16994

This matters at least for the mincore syscall, which will otherwise copy
uninitialized memory from the page allocator to userspace.  It is
probably also a correctness error for /proc/$pid/pagemap, but I haven't
tested that.

Removing the `walk->hugetlb_entry` condition in walk_hugetlb_range() has
no effect because the caller already checks for that.

This only reports holes in hugetlb ranges to callers who have specified
a hugetlb_entry callback.

This issue was found using an AFL-based fuzzer.

v2:
 - don't crash on ->pte_hole==NULL (Andrew Morton)
 - add Cc stable (Andrew Morton)

Fixes: 1e25a271c8ac ("mincore: apply page table walker on do_mincore()")
Signed-off-by: Jann Horn <jannh@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
(cherry picked from commit 373c4557d2aa362702c4c2d41288fb1e54990b7c)
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Acked-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
Acked-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
mm/pagewalk.c