]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit - mm/swapfile.c
mm: fix a race on nr_swap_pages
authorZhaoyang Huang <huangzhaoyang@gmail.com>
Wed, 16 Dec 2020 04:42:23 +0000 (20:42 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 16 Dec 2020 06:46:15 +0000 (22:46 -0800)
commitb50da6e9f42ade19141f6cf8870bb2312b055aa3
treed504e2dec660733535ee66b19181cbde335b65c5
parent489e9fea66f31086f85d9a18e61e4791d94a56a4
mm: fix a race on nr_swap_pages

The scenario on which "Free swap = -4kB" happens in my system, which is caused
by several get_swap_pages racing with each other and show_swap_cache_info
happens simutaniously. No need to add a lock on get_swap_page_of_type as we
remove "Presub/PosAdd" here.

ProcessA ProcessB ProcessC
ngoals = 1 ngoals = 1
avail = nr_swap_pages(1) avail = nr_swap_pages(1)
nr_swap_pages(1) -= ngoals
nr_swap_pages(0) -= ngoals
nr_swap_pages = -1

Link: https://lkml.kernel.org/r/1607050340-4535-1-git-send-email-zhaoyang.huang@unisoc.com
Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/swapfile.c