]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - net/ceph/osd_client.c
libceph: fix a osd request memory leak
authorAlex Elder <elder@inktank.com>
Sat, 16 Feb 2013 04:10:17 +0000 (22:10 -0600)
committerSage Weil <sage@inktank.com>
Thu, 2 May 2013 04:14:22 +0000 (21:14 -0700)
commit3ff5f385b1449a07372d51fb89ca94dbfb6a3be2
tree0d902d547dc2f9efe843b94d6a88478563e5e240
parentc1be5a5b1b355d40e6cf79cc979eb66dafa24ad1
libceph: fix a osd request memory leak

If an invalid layout is provided to ceph_osdc_new_request(), its
call to calc_layout() might return an error.  At that point in the
function we've already allocated an osd request structure, so we
need to free it (drop a reference) in the event such an error
occurs.

The only other value calc_layout() will return is 0, so make that
explicit in the successful case.

This resolves:
    http://tracker.ceph.com/issues/4240

Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
net/ceph/osd_client.c