]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit - net/core/bpf_sk_storage.c
bpf: Acquire map uref in .init_seq_private for sock local storage map iterator
authorHou Tao <houtao1@huawei.com>
Wed, 10 Aug 2022 08:05:32 +0000 (16:05 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 17 Oct 2022 09:57:17 +0000 (11:57 +0200)
commite60c7a9fc3b7f3ae1ae4383a43ce1a74111b91f6
treec7a05ca7e0d5e3617222f78edd52f9cdd39775e1
parent4d51abaa120819ffffa85d3e119b83733d2b250b
bpf: Acquire map uref in .init_seq_private for sock local storage map iterator

BugLink: https://bugs.launchpad.net/bugs/1990564
commit 3c5f6e698b5c538bbb23cd453b22e1e4922cffd8 upstream.

bpf_iter_attach_map() acquires a map uref, and the uref may be released
before or in the middle of iterating map elements. For example, the uref
could be released in bpf_iter_detach_map() as part of
bpf_link_release(), or could be released in bpf_map_put_with_uref() as
part of bpf_map_release().

So acquiring an extra map uref in bpf_iter_init_sk_storage_map() and
releasing it in bpf_iter_fini_sk_storage_map().

Fixes: 5ce6e77c7edf ("bpf: Implement bpf iterator for sock local storage map")
Signed-off-by: Hou Tao <houtao1@huawei.com>
Acked-by: Yonghong Song <yhs@fb.com>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Link: https://lore.kernel.org/r/20220810080538.1845898-4-houtao@huaweicloud.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
net/core/bpf_sk_storage.c