]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - net/core/dev.c
net: avoid skb_warn_bad_offload on IS_ERR
authorWillem de Bruijn <willemb@google.com>
Tue, 12 Dec 2017 16:39:04 +0000 (11:39 -0500)
committerSeth Forshee <seth.forshee@canonical.com>
Wed, 28 Feb 2018 14:46:41 +0000 (08:46 -0600)
commitd0444a292d40e29c4356934a9f8a5842487dae9c
tree35de346f217c897312bce5f3f85ed1344c0af0a1
parent00355f2e1a00cf35221835f67796fa3b98061732
net: avoid skb_warn_bad_offload on IS_ERR

BugLink: http://bugs.launchpad.net/bugs/1752119
commit 8d74e9f88d65af8bb2e095aff506aa6eac755ada upstream.

skb_warn_bad_offload warns when packets enter the GSO stack that
require skb_checksum_help or vice versa. Do not warn on arbitrary
bad packets. Packet sockets can craft many. Syzkaller was able to
demonstrate another one with eth_type games.

In particular, suppress the warning when segmentation returns an
error, which is for reasons other than checksum offload.

See also commit 36c92474498a ("net: WARN if skb_checksum_help() is
called on skb requiring segmentation") for context on this warning.

Signed-off-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
net/core/dev.c