]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - net/core/rtnetlink.c
rtnetlink: NUL-terminate IFLA_PHYS_PORT_NAME string
authorMichal Schmidt <mschmidt@redhat.com>
Thu, 4 May 2017 14:48:58 +0000 (16:48 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 4 May 2017 15:23:59 +0000 (11:23 -0400)
commit77ef033b687c3e030017c94a29bf6ea3aaaef678
tree7cbda1d9da4a351e5ec1924c6ffabc7883599329
parent2be0f2644598ee4b8ea0ed6a32913e1ce0212c9c
rtnetlink: NUL-terminate IFLA_PHYS_PORT_NAME string

IFLA_PHYS_PORT_NAME is a string attribute, so terminate it with \0.
Otherwise libnl3 fails to validate netlink messages with this attribute.
"ip -detail a" assumes too that the attribute is NUL-terminated when
printing it. It often was, due to padding.

I noticed this as libvirtd failing to start on a system with sfc driver
after upgrading it to Linux 4.11, i.e. when sfc added support for
phys_port_name.

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/rtnetlink.c