]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - net/ipv4/tcp_ipv4.c
tcp: Don't change unlocked socket state in tcp_v4_err().
authorDavid S. Miller <davem@davemloft.net>
Fri, 12 Nov 2010 21:35:00 +0000 (13:35 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 12 Nov 2010 21:35:00 +0000 (13:35 -0800)
commit8f49c2703b33519aaaccc63f571b465b9d2b3a2d
tree3b2db10ae8642c87c7258522e06ee56910d5b420
parent5ef41308f94dcbb3b7afc56cdef1c2ba53fa5d2f
tcp: Don't change unlocked socket state in tcp_v4_err().

Alexey Kuznetsov noticed a regression introduced by
commit f1ecd5d9e7366609d640ff4040304ea197fbc618
("Revert Backoff [v3]: Revert RTO on ICMP destination unreachable")

The RTO and timer modification code added to tcp_v4_err()
doesn't check sock_owned_by_user(), which if true means we
don't have exclusive access to the socket and therefore cannot
modify it's critical state.

Just skip this new code block if sock_owned_by_user() is true
and eliminate the now superfluous sock_owned_by_user() code
block contained within.

Reported-by: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
CC: Damian Lukowski <damian@tvk.rwth-aachen.de>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
net/ipv4/tcp_ipv4.c