]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - net/ipv6/route.c
ipv6: If neigh lookup fails during icmp6 dst allocation, propagate error.
authorDavid S. Miller <davem@davemloft.net>
Tue, 13 Dec 2011 21:48:21 +0000 (16:48 -0500)
committerDavid S. Miller <davem@davemloft.net>
Tue, 13 Dec 2011 21:51:51 +0000 (16:51 -0500)
commitb43faac69062f0fc75bd3230d67da64e184232d1
tree0b6c90f5a2fb9e07d2fce5b57fabc8cf6580aaeb
parent5c3ddec73d01a1fae9409c197078cb02c42238c3
ipv6: If neigh lookup fails during icmp6 dst allocation, propagate error.

Don't just succeed with a route that has a NULL neighbour attached.
This follows the behavior of addrconf_dst_alloc().

Allowing this kind of route to end up with a NULL neigh attached will
result in packet drops on output until the route is somehow
invalidated, since nothing will meanwhile try to lookup the neigh
again.

A statistic is bumped for the case where we see a neigh-less route on
output, but the resulting packet drop is otherwise silent in nature,
and frankly it's a hard error for this to happen and ipv6 should do
what ipv4 does which is say something in the kernel logs.

Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/route.c