]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - net/ipv6/sit.c
ipv6: get rid of ipip6_prl_lock
authorEric Dumazet <eric.dumazet@gmail.com>
Tue, 1 Jun 2010 07:26:58 +0000 (00:26 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 1 Jun 2010 07:26:58 +0000 (00:26 -0700)
commitaac4dddc358acfd9d98b20024a42c34dfab31c39
tree08c9bb6dcbb45673ded4e63ea676f54f9abf8180
parent95e3bb7aff59d3b6c73d55d1a386ee53b8363fb5
ipv6: get rid of ipip6_prl_lock

As noticed by Julia Lawall, ipip6_tunnel_add_prl() incorrectly calls
kzallloc(..., GFP_KERNEL) while a spinlock is held. She provided
a patch to use GFP_ATOMIC instead.

One possibility would be to convert this spinlock to a mutex, or
preallocate the thing before taking the lock.

After RCU conversion, it appears we dont need this lock, since
caller already holds RTNL

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/sit.c