]> git.proxmox.com Git - mirror_qemu.git/commit - net/net.c
net: Don't use error_is_set() to suppress additional errors
authorMarkus Armbruster <armbru@redhat.com>
Thu, 24 Apr 2014 13:44:18 +0000 (15:44 +0200)
committerStefan Hajnoczi <stefanha@redhat.com>
Fri, 25 Apr 2014 13:58:07 +0000 (15:58 +0200)
commit9083da1d4c9dfff30d411f8c73ea494e9d78de1b
treebd1697a4dc3146b5dfe3f4767d9ec0430dfc75d3
parent638fb14169ad96cf9bc0dd5f61460daaecee5bb1
net: Don't use error_is_set() to suppress additional errors

Using error_is_set(errp) that way can sweep programming errors under
the carpet when we get called incorrectly with an error set.

qmp_query_rx_filter() breaks its loop when it detects an error.  It
needs to set another error when the loop completes normally.

Return right away instead of merely breaking the loop.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
net/net.c